search

zeta-chain / protocol-contracts-solana

solana interface contract for zetachain
MIT License
5 stars 2 forks source link

add: ops script to initialize gateway program #20

Open brewmaster012 opened 2 months ago

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.17%. Comparing base (08b8147) to head (3a7e0d5). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ===================================== Coverage 9.17% 9.17% ===================================== Files 1 1 Lines 218 218 ===================================== Hits 20 20 Misses 198 198 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brewmaster012 commented 1 month ago

thanksf or the comments, but to clarify: the ops script serves two purposes:

  1. as a log of deployment
  2. template for deployment for mainnet

This is one-off script (at most two-off). The commented code is there to prevent accidental re-deployment and can be uncommented for mainnet deployment.

As long as it works I will not further improve it.

lumtis commented 1 month ago

thanksf or the comments, but to clarify: the ops script serves two purposes:

  1. as a log of deployment
  2. template for deployment for mainnet

This is one-off script (at most two-off). The commented code is there to prevent accidental re-deployment and can be uncommented for mainnet deployment.

As long as it works I will not further improve it.

Not sure to understand the point. If the script is not used in practice and just as a template, the we can have a playbook instead of it. If the script is aimed to be used in production, we should have production grade code. Having commented code for no reason is confusing, we should write code as if an entirely new team could take ownership of the codebase and know how to use the script.