zeta-chain / protocol-contracts-solana

solana interface contract for zetachain
3 stars 2 forks source link

fix: solana-test-validator macos error, expects gnu-tar (#22) #23

Closed abhijayrajvansh closed 2 weeks ago

abhijayrajvansh commented 2 weeks ago

This PR updates the troubleshooting part of the documentation regarding macOS error #22

This is because the BSD tar program is not compatible with the GNU tar program.

To fix it: you need to install and export the executable path of your GNU tar program in your .zshrc file.

Mac with Apple Silicon

brew install gnu-tar
# Put this in ~/.zshrc 
export PATH="/opt/homebrew/opt/gnu-tar/libexec/gnubin:$PATH"

Intel-based Mac

brew install gnu-tar
# Put this in ~/.zshrc 
export PATH="/usr/local/opt/gnu-tar/libexec/gnubin:$PATH"

the only reason there are separate exports for intel-based macs and macs with apple silicon is that, by default, homebrew executables are stored at different locations for macs with respective chipset.

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.17%. Comparing base (3bc8dad) to head (0de4ded). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ===================================== Coverage 9.17% 9.17% ===================================== Files 1 1 Lines 218 218 ===================================== Hits 20 20 Misses 198 198 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fbac commented 2 weeks ago

@abhijayrajvansh thanks for the contribution. Changes LGTM, but the commits have to be signed in order to be merged. Something like git rebase --signoff HEAD~1 should work.

abhijayrajvansh commented 2 weeks ago

@fbac yessir, done 👍

fbac commented 2 weeks ago

Thanks @abhijayrajvansh, I'm afraid the commit is still not signed and that's why the merge is blocked.

abhijayrajvansh commented 2 weeks ago

ah silly me, have signed and verified the commit again — hopefully, it'll work this time.

thanks @fbac for your patience and guidance.

fbac commented 2 weeks ago

Thanks for the contribution @abhijayrajvansh :)