search

zeta-chain / protocol-contracts

Protocol contracts implementing the core logic of the protocol, deployed on ZetaChain and on connected chains
MIT License
70 stars 58 forks source link

fix: duplicate addresses #145

Closed fadeev closed 5 months ago

fadeev commented 6 months ago
fadeev commented 6 months ago

@brewmaster012 @lumtis please, review. Need a second review.

lumtis commented 5 months ago

@fadeev I solved the conflict in package.json here since it was just about removing a comma but it seems generate files is failing now, do you know the reason?

skosito commented 5 months ago

@fadeev I solved the conflict in package.json here since it was just about removing a comma but it seems generate files is failing now, do you know the reason?

it seems that one of those 2 is not iterable and spread operator is used on them, i can also check:

 const networks = [...mainnet, ...testnet];

also maybe related to yarn version change there is duplicate entry in package.json, will remove it

EDIT: this did the trick, approving PR again