Closed skosito closed 4 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Even though we have the OZ docs, I think it would be great to add a test to show how the upgrade process would look like
added this
one more thing in upgrade process on real networks would be to track network files in source control https://docs.openzeppelin.com/upgrades-plugins/1.x/network-files
where things like storage layout, implementation contracts address etc would be stored, so when there is upgrade, plugin would validate that storage layout is not broken etc.
but i guess we can discuss that once we move from PoC to livenet deployments
@coderabbitai review
Using openzeppelin hardhat upgrades, and UUPS proxy.
Resources: https://docs.openzeppelin.com/upgrades-plugins/1.x/writing-upgradeable
UUPS vs Transparent Proxy: https://docs.openzeppelin.com/contracts/4.x/api/proxy#transparent-vs-uups
Had to go with lower package versions because ethers 5 is used. We should consider bumping ethers and other packages.