Closed fbac closed 2 months ago
Recent updates focus on enhancing the build and testing workflows for the project. The main changes include substituting yarn compile
with yarn build
in various scripts and configurations, adjusting Slither's execution settings, and introducing a new Mocha timeout configuration. These modifications streamline the build process, improve testing efficiency, and make the workflows more robust and adaptable.
File | Change Summary |
---|---|
.github/workflows/slither.yaml |
Replaced yarn compile with yarn build in the Install dependencies job and added ignore-compile: true to the slither job. |
hardhat.config.ts |
Added a new Mocha configuration with a timeout value of 100000. |
slither.config.json |
Updated the setting to "foundry_ignore_compile": true . |
package.json |
Modified the test:prototypes script to run tests directly without yarn compile . |
.github/workflows/test.yaml |
Added a new step to build the project using yarn build . |
In the realm of code, a change took place,
Withyarn build
now setting the pace,
Mocha's timeout, a longer grace,
Slither's tweaks, a sleeker face.
Improved workflows, a worthy embrace,
Our code marches forth, in steady trace.
🌟🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@fbac @lumtis nodejs is bumped to 20 and i removed test:prototypes step because it is inlcuded with yarn test
and i removed yarn forge
from test workflow for now, when we add more tests we should add it as separate job
@fbac @lumtis nodejs is bumped to 20 and i removed test:prototypes step because it is inlcuded with
yarn test
and i removedyarn forge
from test workflow for now, when we add more tests we should add it as separate job
LGTM!
@fbac @lumtis nodejs is bumped to 20 and i removed test:prototypes step because it is inlcuded with
yarn test
and i removedyarn forge
from test workflow for now, when we add more tests we should add it as separate jobLGTM!
i think we can merge this one
Ignore foundry compilation when running slither as a CLI and in CI.
Summary by CodeRabbit
yarn build
instead ofyarn compile
for consistency in build processes.package.json
scripts to streamline testing by removing redundant compile steps.