Closed skosito closed 2 months ago
The recent changes enhance the GitHub Actions workflows for project management, emphasizing versioning and streamlining processes specific to the 'v1' and 'v2' directories. Key updates include revised workflow names, newly defined triggers based on directory paths, and centralized working directories. These improvements reflect a focus on better organization, efficiency in testing, linting, and publishing tasks, as well as a clearer setup for tools and dependencies.
Files | Change Summary |
---|---|
*.github/workflows/generated-files_.yaml** | Workflows renamed to "Generated Files are Updated (V1/V2)", restricted to v1/** and v2/** , added working directory defaults. |
*.github/workflows/lint_.yaml** | Workflows renamed to "Lint TS/JS (V1)" and "Lint TS/JS/Sol (V2)", restricted to v1/** and v2/** , updated Node.js version, added Foundry installation, and adjusted steps accordingly. |
.github/workflows/publish-npm_v1.yaml | Renamed to "Publish to NPM (V1)", added working directory defaults, removed submodule checkout. |
.github/workflows/slither_v2.yaml | Renamed to "Slither (V2)", updated to v2/** , upgraded checkout and Node.js versions, changed build command to forge build . |
*.github/workflows/test_.yaml** | Workflows renamed to "Test (V1)" and "Test (V2)", adjusted to v1/** and v2/** , removed Foundry installation, and introduced Hardhat testing. |
.gitignore | New entry broadcast added to ignore files related to broadcasting. |
.gitmodules | Submodule paths updated to v2/ , indicating a reorganization of dependencies. |
README.md | New file introduced outlining the ZetaChain Protocol Contracts, linking to relevant resources. |
sequenceDiagram
participant User
participant GitHubActions as GHA
participant Node as NodeJS
participant Tools as Tools
participant Repo as Repository
User->>GHA: Push changes to v1 or v2
GHA->>Repo: Check out code
GHA->>Node: Set up Node environment
GHA->>Tools: Run linting/tests
Tools->>GHA: Return results
GHA->>User: Notify completion
π
In the meadow, changes bloom,
New workflows rise, dispelling gloom.
With paths defined and tools in hand,
Our projects flourish, oh so grand!
Hopping forward, we'll take flight,
Celebrating code, our delight!
πΌ
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 51.35%. Comparing base (
2ea8f56
) to head (640e67d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lumtis i think all these issues can be closed with this PR, please let me know if that is not the case: https://github.com/zeta-chain/protocol-contracts/issues/263 https://github.com/zeta-chain/protocol-contracts/issues/238 https://github.com/zeta-chain/protocol-contracts/issues/193 https://github.com/zeta-chain/protocol-contracts/issues/192 https://github.com/zeta-chain/protocol-contracts/issues/156
Summary by CodeRabbit
README.md
file providing an overview of the ZetaChain Protocol Contracts, including links to official resources and details on legacy and new contract versions..gitignore
entry forbroadcast
to maintain a cleaner repository..gitmodules
to reflect a more modular organization.