coderabbitai[bot]
commented
2 months ago Walkthrough
## Walkthrough This pull request introduces significant modifications to the `GatewayEVM` and `GatewayZEVM` contracts, focusing on the execution of calls with new structures for handling call options, including gas limits. The `go.mod` file reflects updates to various dependencies, including downgrades and the addition of new libraries. The changes enhance the functionality and clarity of the contracts, particularly in managing authenticated and arbitrary calls, while also improving the testing framework to cover new scenarios. ## Changes | File | Change Summary | |-------------------------------------------|----------------------------------------------------------------------------------------------------| | `go.mod` | Updated dependency versions, including downgrades and the addition of a new dependency. | | `v2/contracts/evm/GatewayEVM.sol` | Removed `_execute` function; added `_executeAuthenticatedCall` and `_executeArbitraryCall`. Overloaded `execute` function to support a `MessageContext`. | | `v2/contracts/evm/interfaces/IGatewayEVM.sol` | Added new error and methods; introduced `MessageContext` struct and `Callable` interface. | | `v2/contracts/zevm/GatewayZEVM.sol` | Introduced `CallOptions` struct for call parameters; added `withdrawAndCall` and `call` functions. | | `v2/contracts/zevm/interfaces/IGatewayZEVM.sol` | Updated events to use `CallOptions`; added new functions for withdrawals and calls. | | `v2/test/GatewayEVM.t.sol` | Added new test functions for `gateway.execute` scenarios, enhancing coverage for authorization checks. | | `v2/test/GatewayEVMZEVM.t.sol` | Updated imports and function calls to utilize `CallOptions`. | | `v2/test/GatewayZEVM.t.sol` | Modified tests to incorporate `CallOptions` in various withdrawal and call scenarios. | | `v2/test/utils/GatewayEVMUpgradeTest.sol`| Removed `_execute`; added new functions for authenticated and arbitrary calls. | | `v2/test/utils/IReceiverEVM.sol` | Added `ReceivedOnCall` event to the interface. | | `v2/test/utils/ReceiverEVM.sol` | Introduced `onCall` function to handle calls with `MessageContext`. | ## Possibly related issues - **zeta-chain/protocol-contracts#307**: The changes in this PR address the need for a `GasLimit` option in the `call` and `withdrawAndCall` functions, as outlined in the issue. ## Possibly related PRs - **#352**: This PR involves modifications to the `GatewayZEVM` contract structure and functionality, which may relate to the dependency updates in the main PR. ## Suggested reviewers - fadeev - CharlieMc0 - brewmaster012 - andresaiello - fbac - lumtisThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov-commenter
skosito
same as: https://github.com/zeta-chain/protocol-contracts/pull/350 just correct base branch and onCall function payable
Summary by CodeRabbit
Release Notes
New Features
GatewayEVMandGatewayZEVMcontracts.CallOptionsstructure for standardized call parameters, improving clarity in function calls.onCallfunction inReceiverEVMcontract to handle incoming calls with context.ReceivedOnCalladded for better event handling inIReceiverEVMEvents.Bug Fixes
Tests
GatewayEVMandGatewayZEVMwith new scenarios and validation checks.CallOptionsstructure for consistency.