coderabbitai[bot]
commented
1 month ago [!IMPORTANT]
Review skipped
Review was skipped due to path filters
:no_entry: Files ignored due to path filters (37)
* `v2/docs/src/contracts/Revert.sol/interface.Revertable.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/Revert.sol/struct.RevertContext.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/Revert.sol/struct.RevertOptions.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/ERC20Custody.sol/contract.ERC20Custody.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/GatewayEVM.sol/contract.GatewayEVM.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/ZetaConnectorBase.sol/abstract.ZetaConnectorBase.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/ZetaConnectorNative.sol/contract.ZetaConnectorNative.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/ZetaConnectorNonNative.sol/contract.ZetaConnectorNonNative.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IERC20Custody.sol/interface.IERC20Custody.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IERC20Custody.sol/interface.IERC20CustodyErrors.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IERC20Custody.sol/interface.IERC20CustodyEvents.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IGatewayEVM.sol/interface.Callable.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IGatewayEVM.sol/interface.IGatewayEVM.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IGatewayEVM.sol/interface.IGatewayEVMErrors.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IGatewayEVM.sol/interface.IGatewayEVMEvents.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IGatewayEVM.sol/struct.MessageContext.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IZetaConnector.sol/interface.IZetaConnectorEvents.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/evm/interfaces/IZetaNonEthNew.sol/interface.IZetaNonEthNew.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/GatewayZEVM.sol/contract.GatewayZEVM.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/SystemContract.sol/contract.SystemContract.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/SystemContract.sol/interface.SystemContractErrors.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/ZRC20.sol/contract.ZRC20.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/ZRC20.sol/interface.ZRC20Errors.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IGatewayZEVM.sol/interface.IGatewayZEVM.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IGatewayZEVM.sol/interface.IGatewayZEVMErrors.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IGatewayZEVM.sol/interface.IGatewayZEVMEvents.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IGatewayZEVM.sol/struct.CallOptions.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/ISystem.sol/interface.ISystem.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IWZETA.sol/interface.IWETH9.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IZRC20.sol/enum.CoinType.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IZRC20.sol/interface.IZRC20.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IZRC20.sol/interface.IZRC20Metadata.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/IZRC20.sol/interface.ZRC20Events.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/interface.UniversalContract.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/interface.zContract.md` is excluded by `!v2/docs/**` * `v2/docs/src/contracts/zevm/interfaces/UniversalContract.sol/struct.zContext.md` is excluded by `!v2/docs/**` * `v2/pkg/gatewayevmzevm.t.sol/gatewayevmzevmtest.go` is excluded by `!v2/pkg/**`CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
**/dist/**will override the default block on thedistdirectory.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
📝 Walkthrough
📝 Walkthrough
## Walkthrough The pull request includes significant modifications to the `GatewayEVM` contract, focusing on the removal of the internal `_execute` function and the introduction of new `execute` functions for authenticated and arbitrary calls. Additionally, deposit functionalities for ETH and ERC20 tokens have been enhanced, with new methods allowing deposits followed by calls to specified receivers. The `ZetaConnectorNativeTest` contract has also been updated with new tests for access control and error handling, ensuring robust functionality for contract interactions. ## Changes | File | Change Summary | |-------------------------------------------|---------------------------------------------------------------------------------------------------| | v2/contracts/evm/GatewayEVM.sol | Removed `_execute` function; added multiple `execute` and `deposit` functions; improved input validation. | | v2/test/ZetaConnectorNative.t.sol | Added tests for TSS role management and withdrawal functions; enhanced existing tests for access control. | ## Possibly related PRs - **#361**: Enhances the `GatewayEVM` contract by modifying revert handling and adding a `sender` field to the `RevertContext`, relevant to the `executeRevert` function. - **#363**: Introduces an `updateTSSAddress` function in the `GatewayEVM`, directly related to TSS role management and address updates. ## Suggested reviewers - fadeev - CharlieMc0 - andresaiello - brewmaster012 - lumtis - fbacThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov-commenter
2 things missed in original PR:
Summary by CodeRabbit
New Features
depositAndCall.Bug Fixes
Tests