search

zeta-chain / toolkit

A library of ZetaChain helper utilities, contracts, and Hardhat tasks for smart-contract development
MIT License
43 stars 22 forks source link

Add Solana support to ZetaChain client and browser deposits #199

Open lukema95 opened 4 days ago

lukema95 commented 4 days ago
  1. Add Solana Wallet to ZetaChainClient
  2. Update solanaDeposit to support browser

Related issue #182

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 4 days ago
📝 Walkthrough ## Walkthrough The pull request introduces several enhancements to the `@zetachain/toolkit` project, primarily focusing on integrating Solana wallet support. The `package.json` file is updated to include a new dependency for Solana wallet management. The `ZetaChainClient` class is modified to accommodate Solana wallets, including new properties and methods for wallet management. Additionally, the `solanaDeposit` function is significantly updated to handle Solana transactions and wallet interactions, while a new utility function for keypair retrieval is added in a related task file. ## Changes | File | Change Summary | |-------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `package.json` | - Added dependency: `"@solana/wallet-adapter-react": "^0.15.35"` in `dependencies` section. | | `packages/client/src/client.ts` | - Updated `ZetaChainClientParams` to include `solanaAdapter` and `solanaWallet`.
- Added properties: `public solanaWallet` and `public solanaAdapter` in `ZetaChainClient`.
- Added methods: `isSolanaWalletConnected` and `getSolanaPublicKey`. | | `packages/client/src/solanaDeposit.ts` | - Updated `solanaDeposit` function to check for connected Solana wallet and handle transactions using `solanaAdapter` or `solanaWallet`.
- Removed `idPath` parameter from function arguments. | | `packages/tasks/src/solanaDeposit.ts` | - Added `getKeypairFromFile` function for keypair retrieval.
- Modified `solanaDeposit` function to accept `solanaWallet` and update recipient handling. | ## Possibly related PRs - **#185**: The changes in `package.json` include the addition of a new dependency, which is relevant as the main PR also modifies `package.json` to add a dependency for Solana wallet support. - **#190**: This PR enhances the `account.ts` file to support Solana wallets, which is directly related to the main PR's focus on integrating Solana wallet functionality into the `ZetaChainClient`. ## Suggested reviewers - andresaiello - fadeev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
lukema95 commented 4 days ago

For Cli:

npx hardhat solana-deposit --amount 0.1 --recipient 0x1b02C3079c039DF9E20DC68427cb87bf821BffeF --types '["address", "bytes", "bool"]' 0x05ba149a7bd6dc1f937fa9046a9e05c05f3b18b0 0x4955a3F38ff86ae92A914445099caa8eA2B9bA32 true

For Browser: I wrote a front-end test case here.

image

Final call result: 4CX34eMBpKcSPSjWfcuVa8whPsG1bk7vtrnN5PqvgrM5AZQa9UCTNF6gzKx5KuYfetNSwbhMRw3Gg69Q31Wis3Q7 Note: If you use the Phantom Wallet, you need to set it to developer mode.

lukema95 commented 4 days ago

@fadeev pls review