search

zetachang / react-native-dotenv

A Babel preset let you import application configs from .env file (zero runtime dependency)
MIT License
915 stars 68 forks source link

Suggestion - update README #56

Closed sharoneh closed 5 years ago

sharoneh commented 5 years ago

Got an error like "Cannot read property 'bindings' of null..." when trying to add react-native-dotenv to a project. Found out that in

{
  "presets": ["react-native", "react-native-dotenv"]
}

instead of "react-navite-dotenv" it should be "module:react-native-dotenv" And instead of babel-preset-react-native it should be metro-react-native-babel-preset.

Please, update README to instruct for metro-react-native-babel-preset instead of babel-preset-react-native as it is deprecated and it's been replaced by metro-react-native-babel-preset.

Hope this helps someone.

zetachang commented 5 years ago

Hi, thanks for pointing this out. I would love to merge the PR if you have time to help 😃

Sharon notifications@github.com 於 2019年1月26日 週六 上午1:00 寫道：

Please, update README to instruct for metro-react-native-babel-preset instead of babel-preset-react-native https://www.npmjs.com/package/babel-preset-react-native#this-project-is-deprecated as it is deprecated and it's been replaced by metro-react-native-babel-preset.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zetachang/react-native-dotenv/issues/56, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRJfX4Kb6jtSsyLJkMkFBCcAAkH_joks5vGzgPgaJpZM4aTSRe .