search

zetachang / react-native-dotenv

A Babel preset let you import application configs from .env file (zero runtime dependency)
MIT License
915 stars 68 forks source link

Replace babel-preset-react-native for metro-react-native-babel-preset… #57

Closed sharoneh closed 5 years ago

sharoneh commented 5 years ago

… in README

More information in this issue.

zetachang commented 5 years ago

Hey, thanks for helping out!

So is this package backward compatible ? Or does it only work in the latest version of RN ?

Sharon notifications@github.com 於 2019年1月29日 週二 下午10:28寫道：

… in README

More information in this issue https://github.com/zetachang/react-native-dotenv/issues/56.

You can view, comment on, or merge this pull request online at:

https://github.com/zetachang/react-native-dotenv/pull/57 Commit Summary

  • Replace babel-preset-react-native for metro-react-native-babel-preset in README

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zetachang/react-native-dotenv/pull/57, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzRJedAvk9GpxTqyDkNB-eaN8nzOI1Mks5vIFp2gaJpZM4aYKZX .

-- David Chang

sharoneh commented 5 years ago

I can't tell by what's documented:

This Project Is Deprecated babel-preset-react-native has been replaced by metro-react-native-babel-preset, which now uses Babel 7.0.0. If you're using React Native v0.57 or later you should update your babel config to point to the metro-react-native-babel-preset preset.

chrise86 commented 5 years ago

It still works with RN < 0.56 so I'm not sure why the instructions were removed from the readme 🤷‍♂️