search

zetbaitsu / Compressor

An android image compression library.
7.08k stars 963 forks source link

The <application> tag in `mainfest.xml in the library might be unnecessary #8

Closed fan31415 closed 8 years ago

fan31415 commented 8 years ago

The code below in the libary's manifest.xml is unnecessary and make mistake

<application android:allowBackup="true" android:label="@string/app_name" android:supportsRtl="true" > </application>

When I build gradle, it will tell me the

Attribute application@label value=(@string/application_name) from AndroidManifest.xml:30:9 is also present at {id.zelory:compressor} value=(@string/app_name) Suggestion: add 'tools:replace="android:label"' to <application> element at AndroidManifest.xml:26:5 to override

When I follow the direction I fix this error, however I think maybe removing the tag from library is a better solution for others.

zetbaitsu commented 8 years ago

Thanks