zetkin / app.zetkin.org

Current-generation ("Gen 3") web interface for the Zetkin Platform.
https://app.dev.zetkin.org
23 stars 52 forks source link

Firefox/TextEditor - Bullet never gets removed from Localstorage #1540

Open rebecarubio opened 1 year ago

rebecarubio commented 1 year ago

Description

I used Slate to style my texts in call instructions. Then I made some changes to my text but decided to revert it. Then removed all text styles. After refreshing the page, I expect to have no styles to my texts, but there is and it never disappears.

Error 2. (Check out the video below)

Go to call assignment Go to conversation Add bullet or numeric bullet by using slate in text field. Write a word right next to the bullet or numeric bullet. Save Click the word for editing. Add extra characters to it. You will see "You have unsaved changes. Revert to saved version?" once you make changes to the text. Revert it Remove bullet from the text by using slate. Save it Refresh the page You will see that bullet (if you added numeric bullet before, you will see numeric bullet has changed to bullet) remains still and it will never disappear.

Expected Behaviour

Bullets should be able to be removed perfectly after refreshing the page. Localstorage never removes the "-"

Actual Behaviour

Error occurs when clicking the empty line in slate. Bullets never disappear after refreshing

Screenshots (if you have any)

https://github.com/zetkin/app.zetkin.org/assets/36491300/817b5599-cdf1-40f3-9def-60474d49c611

djbusstop commented 1 year ago

Was able to reproduce with the help of the video. This doesn't happen when you delete the bullet. I think there is a chance this is an issue because the change from bulletted to not bulleted doesn't trigger an "onChange" but this is just an assumption.