search

zetkin / app.zetkin.org

Revamped Zetkin web interface.
https://app-zetkin-org.vercel.app
22 stars 40 forks source link

Merged duplicates are still listed as potential duplicates #2064

Open richardolsson opened 1 week ago

richardolsson commented 1 week ago

Description

After merging a duplicate, it will be marked on the backend as merged. But it is still incorrectly listed on the frontend.

Steps to reproduce

  1. Go to https://app.dev.zetkin.org/organize/1/people/duplicates (and log in)
  2. Click on "Resolve" for any duplicate
  3. Click "Merge"
  4. Refresh the page

Expected Behaviour

The duplicate record should be taken off the list at step 3, and remain off the list in step 4.

Actual Behaviour

The duplicate is removed at step 3 (because it's removed from the cache) but then comes back in step 4. The record that remains can't load the avatars properly, because only one person record remains after the merge.

Screenshots (if you have any)

image

richardolsson commented 1 week ago

Note that this is currently only happening in production. The dev server is still running a prerelease version of the duplicates backend that isn't correctly marking any duplicates as merged, so status: "merged" will never occur on the dev server, although it should.

I will upgrade the dev server in the next week or two so that this bug can be reproduced there.