search

zetkin / lyra

3 stars 3 forks source link

Fine-tune vertical scroll behaviour on the translations page #115

Closed henrycatalinismith closed 4 months ago

henrycatalinismith commented 4 months ago

In https://github.com/zetkin/lyra/pull/107 we've laid down the broad strokes of the translations page. One of the finer details that could do with revisiting is the vertical scroll behaviour of the MessageList component. Currently, the body tag has overflow: hidden on this page, with the vertical scroll on the MessageList instead. This might be nicer if we can figure out how to reinstate the normal body scroll while preserving the other aspects of the layout. Then normal things like pressing space to scroll the page will work. It may also help with an issue where the last MessageForm is partially cut off on mobile (see https://github.com/zetkin/lyra/pull/107#discussion_r1677105963).

henrycatalinismith commented 4 months ago

Hmm not off to a great start. https://github.com/bvaughn/react-window/issues/192

What your'e describing isn't supported by react-window. It was supported by react-virtualized, via a WindowScroller component, but WindowScroller was one of those painful to maintain components.