search

zetkin / organize.zetk.in

Organizer front-end of the Zetkin system for organizing activism
21 stars 14 forks source link

Fix AddViewColumn bug #1263

Closed niklasva82 closed 3 years ago

niklasva82 commented 3 years ago

Fix undocumented bug where adding a view column without selecting anything would add a person_field filter with the configuration of a person_note.

To reproduce:

  1. Create a view
  2. Add a few people to the view
  3. Click Add column
  4. Click the Add column button in the AddViewColumnPane

Expected results: Adds the selected view column type Actual results: Adds a column named Person notes, clears people from the view due to the backend not knowing what to do with the odd column configuration.

niklasva82 commented 3 years ago

In addition to fixing the above bug, this now also fixes a bug where switching between survey response and survey submission would result in weird behavior.