search

zeusops / operationbot

A bot for handling events on the Zeusops discord server
GNU General Public License v3.0
7 stars 4 forks source link

Local time conversion link #74

Closed MaxKosi closed 3 years ago

MaxKosi commented 3 years ago

closes #60

Gehock commented 3 years ago

What's the status of this? It currently marked as a draft

MaxKosi commented 3 years ago

What's the status of this? It currently marked as a draft

Ahh Sorry i'm currently extremely busy with my exam project - so I completely forgot about this. Ill check it but actually think that should be done

MaxKosi commented 3 years ago

Rebased and ready for Review (I hope)

MaxKosi commented 3 years ago

It's showing the changed files of the rebase as well. Did I fuck up again?

Gehock commented 3 years ago

It's showing the changed files of the rebase as well.

You'll have to rebase the changes and do a force-push to the branch, not a merge

MaxKosi commented 3 years ago

Yeah I dont know why I always merge after that. It is pushed now. But the commits exist twice now because of that. Needs some cleaning...

Gehock commented 3 years ago

Something funny still happening here, this PR seems to revert most of the changes from #71

MaxKosi commented 3 years ago

You are right, and I found the issue. I shouldnt have renamed but added a second var

MaxKosi commented 3 years ago

I would change Line 217 https://github.com/zeusops/operationbot/blob/2d1c24accafaafb3ecda17e35e27847ae3193f88/event.py#L217 to this: self.title, self.date.strftime(f"%a %Y-%m-%d - %H:%M {cfg.TIME_ZONE}"))

and readd the TIME_ZONE back to the config file.

Gehock commented 3 years ago

Squashed instead of just merging because there was a lot of back and forth in the commits, resulting in a fairly small set of changes.