search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
274 stars 84 forks source link

Use POST instead of GET in requests #101

Closed mrbrdo closed 11 years ago

mrbrdo commented 11 years ago

Specs passing, but please test before merging (especially the async option).

mrbrdo commented 11 years ago

should be fixed now. I'm too lazy to fix for 1.8, don't use that ancient tech anymore

mrbrdo commented 11 years ago

@zevarito what's up? :) using this in production, it's working great on 1.9

zevarito commented 11 years ago

Hey @mrbrdo,

Well, has been difficult for me to find time to work on this project.

Can you at least fix specs for JRuby ? https://travis-ci.org/zevarito/mixpanel/builds/7753228

If make that work I will drop 1.8.7 support from now on, update README and push a new version.

Thanks.

mrbrdo commented 11 years ago

can you enable jruby in 1.9 mode on travis? then I can check it out... currently you have 1.8 mode which won't work for same reason as MRI 1.8

zevarito commented 11 years ago

I think you should be able to update .travis.yml file.

Tell me if that doesn't work.

On Sat, Jun 15, 2013 at 8:26 PM, Jan Berdajs notifications@github.comwrote:

can you enable jruby in 1.9 mode on travis? then I can check it out... currently you have 1.8 mode which won't work for same reason as MRI 1.8

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/101#issuecomment-19505220 .

Alvaro