search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
274 stars 84 forks source link

Add redirect_url to tracker #112

Closed reconbot closed 11 years ago

reconbot commented 11 years ago

I needed this to make tracking urls in my emails. I was just going to use build_url (it a great method but it's protected) but I figured a real method is probably the better way to go. I'm flexible on the api, it's the only method that's a departure from the standard func(event, prop, opt). I hope people find it useful.

reconbot commented 11 years ago

Any opposition to dropping ruby 1.8.7? nokogiri (1.6.0) now requires at least ruby 1.9.2. (That's what caused the test to fail.)

zevarito commented 11 years ago

Hey!

I've merged first commit.

I totally agree with drop 1.8.7 support, we should update the README for that, what I am not sure is how is better to have CI running just JRuby 1.9 Mode instead all compatible platforms.

reconbot commented 11 years ago

That is to say why did I drop jruby-18mode when it passed tests? I figured if we're dropping 1.8... I'm happy to submit another pull with it included.