search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

remove ruby 1.8 from travis #122

Closed reconbot closed 11 years ago

reconbot commented 11 years ago

just so our tests are shown as rightfully passing

zevarito commented 11 years ago

I wonder how 1.8 deprecation applies to JRuby, I don't use it so I'd prefer to have more insight before merge this.

Thoughts?

reconbot commented 11 years ago

Depreciation aside I'm actually in favor of remaining 1.8 syntax compatible until we need 1.9 features to operate.

I've been stuck on old versions for various reasons before and had to back port the libraries I needed and it sucks. Hash syntax is the only thing keeping us from supporting 1.8, I say be as inclusive as possible.

I'll be happy to drop 1.8 when 1.9 provides us something we need. On Sep 6, 2013 8:38 PM, "Alvaro Gil" notifications@github.com wrote:

I wonder how 1.8 deprecation applies to JRuby, I don't use it so I'd prefer to have more insight before merge this.

Thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/122#issuecomment-23977934 .

reconbot commented 11 years ago

Confirmed jruby 1.8.7 is around to stay for a while. Closing this branch and fixing the incompatibilities.