search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Added support for https on Ruby 1.9.3 #133

Open manuelmorales opened 10 years ago

manuelmorales commented 10 years ago

Net::HTTP.post_form on Ruby 1.9.3 won't detect the HTTPS protocol and enable SSL. This fix checks the scheme and enables it when necessary.

zevarito commented 10 years ago

Hi @manuelmorales, tests are failing, can you check it out before merge?

Thanks.

manuelmorales commented 10 years ago

Bundle exec rake run green for me. What version of ruby do you use? On 11 Feb 2014 17:09, "Alvaro Gil" notifications@github.com wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing, can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/133#issuecomment-34776353 .

zevarito commented 10 years ago

Is not me is Travis :)

On Tue, Feb 11, 2014 at 7:42 PM, Manuel Morales notifications@github.comwrote:

Bundle exec rake run green for me. What version of ruby do you use? On 11 Feb 2014 17:09, "Alvaro Gil" notifications@github.com wrote:

Hi @manuelmorales https://github.com/manuelmorales, tests are failing, can you check it out before merge?

Thanks.

Reply to this email directly or view it on GitHub< https://github.com/zevarito/mixpanel/pull/133#issuecomment-34776353>

.

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/pull/133#issuecomment-34811218 .

Alvaro

manuelmorales commented 10 years ago

Ups, I didn't notice that I broke the Ruby 1.9.2 build. I just fixed it. Now the build is still broken, but that's because of the already existing problem with JRuby in 1.8 mode.

zevarito commented 10 years ago

Hi @manuelmorales did you know about this project? https://github.com/mixpanel/mixpanel-ruby

It is the official Mixpanel Ruby Gem, I've stopped this Gem development in favor of that one.

Please take a look an tell me if you want to still use this Gem and I'll merge your PR.

Thanks.