search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
274 stars 84 forks source link

Mixpanel 3.0 NameErrror #48

Closed zh4ngx closed 12 years ago

zh4ngx commented 12 years ago

/.rvm/gems/ruby-1.9.3-p194/gems/activesupport-3.2.8/lib/active_support/inflector/methods.rb:230:in `block in constantize': uninitialized constant Mixpanel::Middleware (NameError)

My mixpanel init is ->

Rails.application.config.middleware.use "Mixpanel::Middleware", ENV['MIXPANEL_KEY'], persist: true

Following new Readme...is this incorrect?

zevarito commented 12 years ago

Hi @ZhangBanger,

Could you try the code bellow, I think it should work fine, please tell me how it was.

require 'mixpanel/middleware'

I've yanked the gem until get sometime to see what is happening, but pretty sure that middleware wasn't required when the tracker was. I've fix that soon.

Thanks!

zh4ngx commented 12 years ago

Sure, I'll give that a try. Thanks! On Oct 12, 2012 9:23 AM, "Alvaro Gil" notifications@github.com wrote:

Hi @ZhangBanger https://github.com/ZhangBanger,

Could you try the code bellow, I think it should work fine, please tell me how it was.

require 'mixpanel/middleware'

I've yanked the gem until get sometime to see what is happening, but pretty sure that middleware wasn't required when the tracker was. I've fix that soon.

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/issues/48#issuecomment-9376302.

zevarito commented 12 years ago

@ZhangBanger I've pushed a quick fix for the issue you had. Please use version 3.0.1 of the gem, that should work without requiring the middleware manually, if it works, please come back and close the issue :)

Thanks!

zh4ngx commented 12 years ago

Thanks! Looks like this works for now, after I changed the function names to match 3.0's spec (any particular reason for changing them?)

zevarito commented 12 years ago

Well, it was a kind of code refactor.

Do you think README isn't helping users right now? Should it be changed? Thanks!

zh4ngx commented 12 years ago

I noticed the git changes to readme, but I was a little confused bc of the glitch in 3.0.0. I think you should emphasize the new 3.0.0 syntax in the readme.

On Fri, Oct 12, 2012 at 12:05 PM, Alvaro Gil notifications@github.comwrote:

Well, it was a kind of code refactor.

Do think README isn't helping users right now? Should it be changed? Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/zevarito/mixpanel/issues/48#issuecomment-9381405.