Add support for mixpanel.people.identify, which is different than mixpanel.identify

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.

MIT License

273 stars 84 forks source link

Add support for mixpanel.people.identify, which is different than mixpanel.identify #50

Closed AhmedBelal closed 11 years ago

AhmedBelal commented 11 years ago

There are two different identify methods in Mixpanel's API. I discovered this after calling append_identify followed by append_set. My debugger shows: MIXPANEL PEOPLE REQUEST (QUEUED, PENDING IDENTIFY):

Although distinct id was correctly set for regular events, it was not set for people events.

We need a method _append_peopleidentify that calls append 'people.identify', distinct_id.

AhmedBelal commented 11 years ago

Clarification: It seems that you can call @mixpanel.append('people.identify', distinct_id) and distinct_ids will be set for both your events and your people.set requests but @mixpanel.append('identify', distinct_id) does not set distinct_ids for people requests.

zevarito commented 11 years ago

I'll close this in favor of #51