search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Add support for mixpanel.people.identify #51

Closed AhmedBelal closed 11 years ago

AhmedBelal commented 11 years ago

https://github.com/zevarito/mixpanel/issues/50

zevarito commented 11 years ago

@AhmedBelal Hey!

Sorry has been busy last days.

Does justify the presence of the old method append_identify after adding append_people_identify ?

Should that be deprecated?

Also, please update the README documenting how and why use this method you are adding.

Thanks!

AhmedBelal commented 11 years ago

The old method, append_identify, should not be deprecated since (1) it has not been deprecated in the Mixpanel API, (2) it is appropriate method to use if you're not using Mixpanel People.

zevarito commented 11 years ago

Yeah, well not sure if it should belong to Person class.

I'll will merge and push a new version of the gem this afternoon, I'll let you know. Thanks.

AhmedBelal commented 11 years ago

Yes, append_identity should be moved to the Event class.

zevarito commented 11 years ago

Pushed 3.0.2 version of the gem.

AhmedBelal commented 11 years ago

Great, thanks!