zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Please support https #55

Closed danielribeiro closed 9 years ago

danielribeiro commented 11 years ago

The way it is done now, all data is passed in plain sight.

danielribeiro commented 11 years ago

Well, I ended up fixing a bit their code: https://gist.github.com/4192201

zevarito commented 11 years ago

Hi @danielribeiro,

That should probably end being a clever solution ;)

Anyway, meanwhile, if you still want to use the gem you can override track url option as it shows here:

https://github.com/zevarito/mixpanel#track-events-directly

If you want to contribute to this development you should look at this two files:

https://github.com/zevarito/mixpanel/blob/master/lib/mixpanel/event.rb#L3 https://github.com/zevarito/mixpanel/blob/master/lib/mixpanel/tracker.rb#L16

Probably this all isn't needed since you already figured out, I wouldn't be able to do this because I just realized that this gem is having active_support as dependency, need to solve it first :)

https://github.com/zevarito/mixpanel/blob/master/lib/mixpanel/event.rb#L25