search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Updated boilerplate javascript to the latest version. It was changed to support the new integration with Optimizely. #58

Closed cburnette closed 11 years ago

cburnette commented 11 years ago

This is required to support Optimizely integration.  See here for explanation: http://support.optimizely.com/customer/portal/articles/605823-how-can-i-integrate-optimizely-with-mixpanel-

zevarito commented 11 years ago

I'll check this tomorrow, thanks. Meanwhile can you look at the test suite?

cburnette commented 11 years ago

hey, the thing I'm not sure about is that Optimizely announced their integration with Mixpanel two weeks ago and posted this updated javascript. We've been using it successfully for about a week now and it doesn't appear to have affected the normal Mixpanel operations at all. However, if you look at Mixpanel's documentation they still have the old javascript. So I'm not sure what the current state is. I looked into the failed test and it's a problem with JRuby and it looks like it's looking here:

Using /home/travis/.rvm/gems/jruby-1.7.0

even though it's described as a jruby-18mode. It's failing to install debugger-linecache. I'm not familiar with JRuby at all.

thanks!

chad burnette

vp – engineering | zenph inc. 2 Davis Drive, PO 12076, Research Triangle Park, Durham, NC 27709 chad@zenph.com | www.zenph.com | +1.919.607.4063

On Dec 5, 2012, at 7:16 PM, Alvaro Gil notifications@github.com wrote:

I'll check this tomorrow, thanks. Meanwhile can you look at the test suite?

— Reply to this email directly or view it on GitHub.

zevarito commented 11 years ago

Yeah, I am not sure about this change. I think this should be optional at least for a while.

About tests, it is probably Regex not matching the new Javascript snippet.