zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.

MIT License

274 stars 84 forks source link

Add support for $ignore_time and $ip options on people properties #64

Closed kevinmook closed 11 years ago

kevinmook commented 11 years ago

Mixpanel supports {$ignore_time: true} and {$ip: 0} properties when setting people properties. This tells mixpanel to not update the "$last_seen" property and the user's ip, respectively, when applying the people properties. These properties are in the same part of the dictionary as $distinct_id (outside of the $set dictionary).

zevarito commented 11 years ago

Hi @kevinmook,

Please see my comment here: https://github.com/zevarito/mixpanel/issues/59#issuecomment-11640333

This code looks good, I just want to point out a few things:

Would be great to support old IP resolution as it is in: https://github.com/zevarito/mixpanel/blob/master/lib/mixpanel/event.rb#L30
This doesn't break the build, but would be cool to add a test for new features.
Readme file should reflect this new usage.

Thanks!

zevarito commented 11 years ago

62 Was merged, please see comments on #59. Thanks.