zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Properly pass config to Mixpanel middleware #85

Closed akatz closed 11 years ago

akatz commented 11 years ago

The Mixpanel::Middleware takes options as the second argument, and the primary key of the hash needs to be :config

zevarito commented 11 years ago

Hi @akatz not sure about this being more clear than what is there right now. Take a look at Readme, it says "Where options is a hash that accepts the following keys" and then all possible keys including config are listed.

I'll close this PR, please let me know if I missed something. Thanks!