search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

2.2 javascript #89

Closed michaelglass closed 11 years ago

michaelglass commented 11 years ago

brought over milo's 2.2 changes. This is not backwards compatible, so bumped version to 4

specifically: people.identify is gone.

zevarito commented 11 years ago

This build is failing, also please don't bump versions. Thanks.

zevarito commented 11 years ago

So, if build starts to succeed, I think it should be merged.

michaelglass commented 11 years ago

thanks zevarito.

I think the test suite seems kind of weak. Mostly syntax checking. Maybe an optional integration test against a set of test credentials to ensure that all api methods are still supported? This isn't the right place for this kind of conversation, so maybe I'll open an issue.

zevarito commented 11 years ago

merged