search

zevarito / mixpanel

Simple lib to track events in Mixpanel service. It can be used in any rack based framework.
MIT License
273 stars 84 forks source link

Add Alias Helper Method #92

Closed tyre closed 11 years ago

tyre commented 11 years ago

For consistency with the JS API, I added a helper method that mimics mixpanel.alias to allow a user to execute something like:

Mixpanel.alias('bubbles', {distinct_id: 'walrus'})
michaelglass commented 11 years ago

think it looks good. for consistency, it should either go in person (fine) or append_alias should also move into event (probably better, I think only things that hit the /engage endpoint should end in person.rb)

tyre commented 11 years ago

I can move append_alias for consistency. I'll update with that change.

tyre commented 11 years ago

updated.

michaelglass commented 11 years ago

:poop: :+1: :+1: :+1: :+1: :poop:

michaelglass commented 11 years ago

@zevarito MAKE THE MAGIC HAPPEN

zevarito commented 11 years ago

Hey guys, I am back.

So, haven't much time to look at this, but I think you should add a test and update documentation, then I think it is fine to merge.

tyre commented 11 years ago

Updated the readme and added some rspec tests. Let me know if there is anything else I can dol :)

zevarito commented 11 years ago

Hi @tyre,

Sorry I could not use time on the project until now.

Seems like build is failing again right?

tyre commented 11 years ago

I just ran them again to confirm but I show

Finished in 1.05 seconds
74 examples, 0 failures

Which ones are failing?

tyre commented 11 years ago

Ah zut alors, I have updated that line and Travis is happy again :)

zevarito commented 11 years ago

Merged, thanks.