zevlg / telega.el

GNU Emacs telegram client (unofficial)
https://zevlg.github.io/telega.el/
GNU General Public License v3.0
1.09k stars 85 forks source link

add customization option for message reaction inserter #466

Closed macovsky closed 4 months ago

macovsky commented 4 months ago

what do you think about such cosmetic change?

IMO this way it looks better since user sees up to three avatars anyways

zevlg commented 4 months ago

There are few things to consider about this modification: 1) For blind telega users it is very useful to see number of reactions before taking any action, so this must be customizable after all 2) Recent reaction senders are not always available, so you won't be able to distinguish single reaction from double reaction 3) User might customize telega-avatar-text-function, so in nox-emacs he might not see recent reactions avatars at all even if the list of recent reaction senders is available

It is better to advice telega-ins--msg-reaction to implement custom behaviour you need

macovsky commented 4 months ago

There are few things to consider about this modification:

  1. For blind telega users it is very useful to see number of reactions before taking any action, so this must be customizable after all
  2. Recent reaction senders are not always available, so you won't be able to distinguish single reaction from double reaction
  3. User might customize telega-avatar-text-function, so in nox-emacs he might not see recent reactions avatars at all even if the list of recent reaction senders is available

good points of course, thanks for going into details!

It is better to advice telega-ins--msg-reaction to implement custom behaviour you need

will try to make it!

macovsky commented 4 months ago

@zevlg added a customization option like you adviced

zevlg commented 4 months ago

Merged in, thanks for the contribution!