search

zevv / bucklespring

Nostalgia bucklespring keyboard sound
GNU General Public License v2.0
1.39k stars 82 forks source link

About Windows build #112

Closed 3N4N closed 1 year ago

3N4N commented 1 year ago

In the readme, it says, "I think the windows build is currently broken." I just tried it out, and it worked fine.

The makefile didn't work for me, though. I'm using MSys2/mingw64 toolchain. I don't think that's handled in the makefile. I created a cmakefile. But after than everything was simple.

I'll try to build with msvc if you want. Otherwise, I just wanted to say bucklespring works on Windows, too.

(By the way, if you wanna update your makefile to handle msys, I can help. Using cmake probably would've been better, but I don't think you'd be willing to change the whole project structure.)

3N4N commented 1 year ago

@zevv without any feedback within the next Sunday, I'll close this issue (on 26th).

zevv commented 1 year ago

Hey Enan, sorry for the silence - I don't spend too much time on buckle anymore, as is probably obvious from the lack of commits and other activity here.

Hostly, I don't care about windows myself, as I don't even have a windows machine to test and run it on. If you want to spend the time and effort to make windows a first class citizen I'd gladly pull your PRs, but I'm likely not going to participate in the fun :)

Thanks!

3N4N commented 1 year ago

There is nothing to improve. I just wanted to notify that buckle can be built on Windows without problem. You just need to tweak the makefile a bit. And that, too, for building with MSys2; normal Windows is covered in your makefile. The highest I can contribute is you can add a note to your README or Wiki that any MSys2 user could use the cmakefile in my fork.

Anyway, thanks for the clicky keys. Cheers!