search

zewa666 / aurelia-async-binding

Aurelia async bindingbehavior to consume Observables and Promises
MIT License
18 stars 3 forks source link

Unsubscribe from previous subscription #22

Closed tomasbonco closed 1 year ago

tomasbonco commented 1 year ago

When updateTarget is called multiple times, new subscriptions are created as a result of line 50. However reference to them is lost forever. It causes error messages, where binding.originalupdateTarget is undefined, and potentially could cause memory leaks.

zewa666 commented 1 year ago

@tomasbonco thanks for this one. I took the opportunity to finally update the dependencies and also get a test for your feature in. Should be available via npm within a couple of minutes

tomasbonco commented 1 year ago

Thank you very much. However, I thought that dist folder is generated as a part of the release process. That being said, the change is not reflected in the code that is actually used :(

zewa666 commented 1 year ago

lol, you're right. sorry about that. old project format. I'll add a new release tonight

zewa666 commented 1 year ago

@tomasbonco alright, done now.