search

zewa666 / aurelia-async-binding

Aurelia async bindingbehavior to consume Observables and Promises
MIT License
18 stars 3 forks source link

feat(binding): immediately update the target if the Observable has a BehaviorSubject-like current value member #6

Open james-voth opened 5 years ago

james-voth commented 5 years ago

Hi Vildan. As the title says, this change ensures that the target is immediately updated if the Observable has a BehaviorSubject-like current value member.

zewa666 commented 5 years ago

the request for unit tests was merely to show some use-cases you'd like this addition to handle. Given the above comment I'm not sure what other benefit this could currently have.

james-voth commented 5 years ago

Hi Vildan. My apologies for the delay in responding to your request for unit tests. Indeed, the behaviour that you described in your comment (i.e. the BehaviorSubject firing on subscription as per http://reactivex.io/rxjs/manual/overview.html#behaviorsubject) was what I had expected. However, there were a number of cases where the views were not being updated as expected when they were initially attached.

I will try and extract a minimal reproduction of this in the coming days.

zewa666 commented 4 years ago

@james-voth any updates? did you have a chance to look at it again? Quite a while ago though ;)