search

zewa666 / aurelia-i18next

An Aurelia-Wrapper for the i18next library
MIT License
17 stars 15 forks source link

chore(update): Update to latest releases #31

Closed JeroenVinke closed 9 years ago

JeroenVinke commented 9 years ago

The aurelia plugin api has changed. These changes fixes errors when using the latest updates of Aurelia.

There are two problems when running the tests:

I got 404 errors when running the tests in i18n.update-translations.spec.js. Not sure how to fix this though. This is probably due to running it with jspm@beta

WARN [web-server]: 404: /base/test/unit/fixtures/github:systemjs/plugin-text@0.0ERROR: 'Potentially unhandled rejection [5] Error: XHR error (404 Not Found) loading http://localhost:9876/base/test/unit/fixtures/github:systemjs/plugin-text@0.0.2.js

And when I disable the i18n.update-translations tests, I get one error (even though it occasionally passes):

Chrome 44.0.2403 (Windows 10 0.0.0) nfvalueconverter tests should display number in the setup locale format by default FAILED
        Expected '123.456,789' to equal '123,456.789'.
            at Object.<anonymous> (D:/Development/aurelia-i18next/test/unit/nfvalueconverter.spec.js:25:43)

I'm not sure if this is due to the changes I've made, or if this problem already existed.

zewa666 commented 9 years ago

@JeroenVinke thanks for the PR, I've fixed the issue with the tests as well ... there was a wrong setting for the System.Path override at the beginning of the mentioned testfile

Btw. if you havent yet signed the Aurelia CLA, please do so

JeroenVinke commented 9 years ago

Thanks! CLA is signed: https://github.com/aurelia/validation/pull/58#issuecomment-105233832

zewa666 commented 9 years ago

@JeroenVinke thank you very much, appreciate your help :+1: