zewa666 / generator-aurelia

Yeoman generator for the JavaScript Framework Aurelia
77 stars 18 forks source link

Implemented usage of personal access token in generator #21

Closed zenvisuals closed 8 years ago

zenvisuals commented 8 years ago

Hi @zewa666 ,

Thanks for creating this generator. It certainly made my life easier in setting up Aurelia.

However, I keep failing to finish the install because of the rate limiting issue in unauthenticated requests to the Github API.

I looked through the code and it seems like we can send authenticated requests to resolve the rate limiting issue. So I have added a few lines of code to use our github access token through our environment variables.

Please review and let me know if you have any issues.

Thanks very much! ZenVisuals

zewa666 commented 8 years ago

Thanks, I totally forgot to add that feature. Great work and thanks for your contribution :+1:

zenvisuals commented 8 years ago

Thanks for the merge and your kind words! :smile:

Have a great day!