Created helpers to sign user id and email

zeyneloz / onesignal-node

A Node.js Library for OneSignal push notification service

MIT License

207 stars 48 forks source link

Closed Larinel closed 3 years ago

Larinel commented 3 years ago

Hi there!

Just added some simple helpers to sign user id and email according to https://documentation.onesignal.com/docs/identity-verification.

Larinel commented 3 years ago

@zeyneloz Hi!

Could you please review this PR? If it's convenient for you.

a-tokyo commented 3 years ago

Great work @Larinel ✨

zeyneloz commented 3 years ago

Thanks for the CR. Looks good to me. Merging.

It would be great if you follow this commit message best practices next time: https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

daveslutzkin commented 3 years ago

Any plans to release this change to npm? Would be handy for us.

daveslutzkin commented 3 years ago

@zeyneloz can you release this? Or would you like me to help by releasing it for you?