Ensure that the vary header is set when no origin is set

zf-fr / zfr-cors

A Zend Framework 2 module that helps you to deal with Cross-Origin Resource Sharing (CORS)

MIT License

60 stars 39 forks source link

Ensure that the vary header is set when no origin is set #31

Closed w3z315 closed 8 years ago

w3z315 commented 8 years ago

Ensure that the vary header is set when no origin is set to prevent reverse proxy caching a wrong request; causing all of the following requests to fail due to missing CORS headers.

w3z315 commented 8 years ago

COVERAGE DECREASED (-1.3%) TO 96.97%; https://coveralls.io/builds/4263540

Unfortunately I can't see the files in coveralls due to a invalid API key for this repository.

bakura10 commented 8 years ago

Thanks. I will have a look at this. Also ping @weierophinney

bakura10 commented 8 years ago

Other than the test and CS, the logic seems good to me.

w3z315 commented 8 years ago

@bakura10 @weierophinney I've cleaned up the code for you

bakura10 commented 8 years ago

Looks good! Just waiting a bit for mwop feedback or otherwhise I'll merge and tag.

Thanks!

weierophinney commented 8 years ago

:+1:

bakura10 commented 8 years ago

Tag as 1.2.1 :).

Thanks!