search

zf-fr / zfr-cors

A Zend Framework 2 module that helps you to deal with Cross-Origin Resource Sharing (CORS)
MIT License
60 stars 39 forks source link

Laminas migration? #62

Open demiankatz opened 4 years ago

demiankatz commented 4 years ago

Just curious if there are plans to move this library to Laminas -- and if so, whether that involves forking the project, issuing a new major version, or something else.

I'm not currently using this -- it's just a component I have been considering for the future -- so please feel no pressure to act on this inquiry. However, I thought I might not be the only one wondering how Laminas will impact it, so I'm opening this issue to capture that answer for future reference. Apologies if this is already documented somewhere and I have missed it!

ddelrio1986 commented 4 years ago

It should work as-is with the laminas-zendframework-bridge. I haven't tested it yet though.

demiankatz commented 4 years ago

@ddelrio1986, I expect that you are correct and this should work fine with the bridge. I'm just curious about long-term plans, since the bridge is intended as a stopgap measure. (And like I say, I'm not trying to rush this along because I have no direct stake in it at the moment ... it's just something that probably needs to be addressed sooner or later).

gburetz commented 4 years ago

This library does not work with the laminas-zendframework-bridge. There are instanceof checks that don't pass.

ddelrio1986 commented 4 years ago

@gburetz thanks for testing that. I think that long-term there should be a new major release that updates all references to laminas.

visto9259 commented 4 years ago

We created the Laminas-Commons organization to host ZF-Commons packages that are migrated to Laminas like ZfcUser and ZfcRbac. It could be the place to host Zfr packages as well. Check out the organization at https://github.com/Laminas-Commons.

alejandro-fiore commented 4 years ago

I made a fork from buddyloans/zfr-cors that was forked from zf-fr/zfr-cors, bump version to 3.0.0 and upload to packagist, so you can use it with Laminas: https://github.com/alejandro-fiore/zfr-cors/

I barely tested, works fine for me!

visto9259 commented 4 years ago

I'll check it out. I am thinking of adding zfr-cors to the Laminas-Commons organization so that it has a home for the future on the Laminas framework.

visto9259 commented 4 years ago

I created Laminas-Commons/LmcCors under the Laminas-Commons organization and ported the master branch of the repo to Laminas. I did not carry over all the previous versions. I also bumped up minimum PHP to 7.2. The namespace was changed to LmcCors and the config key was changed to lmc_cors.
Other than that, they are no changes in functionality. The versioning was reset to 1.0.0. New issues can be submitted and they will be addressed as when I have bandwidth available. The Laminas-Commons organization is opened to people who want to maintain LmcCors in the future. Just let us know and we can add you the Dev team for the library.