Ready for review - Githubissues

zf-fr / zfr-eb-worker

ZfrEbWorker is a thin layer to simplify the usage of SQS queues and Elastic Beanstalk environments

MIT License

8 stars 2 forks source link

Closed bakura10 closed 8 years ago

bakura10 commented 8 years ago

ping @danizord

Few questions:

Should we provide a simple JobInterface wrapper instead of using plain array?
Should we rename this to zfr-eb-worker (as it's really a wrapper to be used with Elastic Beanstalk)
Anything else?

danizord commented 8 years ago

@bakura10 everything looks good for me :clap: :clap:

Should we provide a simple JobInterface wrapper instead of using plain array?

Not needed IMHO. We can handle creation of meaningful command objects in the matched middlewares.

Should we rename this to zfr-eb-worker (as it's really a wrapper to be used with Elastic Beanstalk)

Yeah I prefer zfr-eb-worker.

Anything else?

Great work :+1:

bakura10 commented 8 years ago

Done!

I've completely unit-tested it :).