Wrong docker IP detection with docker for Mac

zf-fr / zfr-eb-worker

ZfrEbWorker is a thin layer to simplify the usage of SQS queues and Elastic Beanstalk environments

MIT License

8 stars 2 forks source link

Closed wysow closed 7 years ago

wysow commented 7 years ago

Here https://github.com/zf-fr/zfr-eb-worker/blob/93078f58a54b623dfa6a28503892f4738ccba957/src/Middleware/WorkerMiddleware.php#L157 the docker IP detection seems to be wrong when using docker for Mac, my container IP is 172.18.0.1 so the right regexp could be something like 172.1*.* maybe...

bakura10 commented 7 years ago

That sounds like a nice tradeoff. Can you make a PR?

wysow commented 7 years ago

Just done ;) if this PR seems OK for you, sounds good for you to tag a new release?