search

zf-fr / zfr-eb-worker

ZfrEbWorker is a thin layer to simplify the usage of SQS queues and Elastic Beanstalk environments
MIT License
8 stars 2 forks source link

Change docker container IP detection #51

Closed wysow closed 7 years ago

wysow commented 7 years ago

Docker container IP detection is not really working when using docker for Mac.

Fix #50

wysow commented 7 years ago

I just found that the async call to send messages in batch is not really working as the promise is never resolved, fixing this in my second commit.

bakura10 commented 7 years ago

Makes sense. However the tests are failing now :)

Envoyé de mon iPhone

Le 29 août 2017 à 18:00, Gaultier Boniface notifications@github.com a écrit :

@wysow commented on this pull request.

In src/MessageQueue/MessageQueue.php:

@@ -151,7 +151,9 @@ private function doFlush(bool $async) }

         if ($async) {
  • $this->sqsClient->sendMessageBatchAsync($parameters);
  • $promise = $this->sqsClient->sendMessageBatchAsync($parameters);
  • $promise->wait(); The commands are sent in parallel in batch of 25 AFAIK.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

bakura10 commented 7 years ago

Just tagged 6.0.2