search

zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

Add support for HHVM #20

Closed bakura10 closed 10 years ago

bakura10 commented 10 years ago

Addresses #18

It removes the constants and returns them in the method. We loose the ability to do "MyGrant::GRANT_TYPE", however.

bakura10 commented 10 years ago

I'm wondering if this should be merged soon, as HHVM supports for overriding constants has been merged a few days ago: https://github.com/facebook/hhvm/commit/8ecf23470b640067ae9daffbaa38f02828ae3996

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.94%) when pulling a6309906cc3079978cee548f351f189bbf026cce on hhvm-support into e59aac4822da14805089f65e82441b075542b315 on master.

bakura10 commented 10 years ago

This passes on nightly of HHVM. So I'll likely close this one for now. If someone has a better idea of the constants, then don't hesitate, but for now I'll stick with that.