Adding revoke rotated refresh token option

zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)

BSD 3-Clause "New" or "Revised" License

36 stars 13 forks source link

Adding revoke rotated refresh token option #56

Closed basz closed 7 years ago

basz commented 7 years ago

part of #54

coveralls commented 7 years ago

Coverage decreased (-0.2%) to 76.074% when pulling 1a3ee6e0c27b20700414e6c8234644e9c1d9235e on basz:adding-revoke-rotated-refresh-token-option into a4b9715a17f9bd1f0d2f3254881162ff75accf68 on zf-fr:master.

basz commented 7 years ago

I did the same thing as other factories do, but would be happy to change it.

Except the next obvious question would be; why not pass the ServerOption instance in the constructor? Ill propose to make a new separate issue for that...

ojhaujjwal commented 7 years ago

@basz good point. go for it.

bakura10 commented 7 years ago

I agree the option should be injected. However for now the feature looks good so I'm merging it !