search

zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

aid IDE hinting by overriding protected with more specialised interface #61

Closed basz closed 8 years ago

basz commented 8 years ago

override properties with more specialised interface as annotations.

will make IDEs' happy (->save method)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling 09e250adc4d8efc29a620ca7dba6ab7cc13974e7 on basz:strict-hinting into 326c56210eef77d70acec0ee11549315af4330a1 on zf-fr:master.

basz commented 8 years ago

@prolic could you have a look pls, especially the second commit...

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling 09e250adc4d8efc29a620ca7dba6ab7cc13974e7 on basz:strict-hinting into 326c56210eef77d70acec0ee11549315af4330a1 on zf-fr:master.

basz commented 8 years ago

https://github.com/zf-fr/zfr-oauth2-server/blob/master/src/Service/AbstractTokenService.php#L59

basz commented 8 years ago

'cause in the extended classes it is known to be AuthorizationCodeRepositoryInterface which extends TokenRepositoryInterface

TokenRepositoryInterface doesn't specify ->save

prolic commented 8 years ago

I see it now. Becoming late here ;-)