search

zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

Minor things #63

Closed basz closed 8 years ago

basz commented 8 years ago

bout done with cleanup

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling 5276d5aeafd7556fa624143309b3936b138c36a3 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling c09a0af5ee23f31619f994686e1126c908e6e4e2 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling c09a0af5ee23f31619f994686e1126c908e6e4e2 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

basz commented 8 years ago

and the last minor thing php71 messes up my evening... :) bedtime

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling 4462a468fbcdaecf4381b3d90835448b9f243af8 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.31% when pulling 197e4aa6fef1e49eb1853e006076523d0b21d3f0 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

prolic commented 8 years ago

Ok seems like conflict is already fixed. Still failing build.

prolic commented 8 years ago

Can you find out why PHP 7.1 is failing?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.2%) to 77.474% when pulling b1d32cff11ef89d8675bf93dd80dee50211a8b0d on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

basz commented 8 years ago

PHP71RC2 is problematic it seems, wait a bit

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.2%) to 85.466% when pulling 3d3f056566eb014fb07810e44d36e903a8643f96 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

basz commented 8 years ago

There know how to fix this warning?

1) ZfrOAuth2Test\Server\Grant\AuthorizationServerAwareTraitTest::testSetAuthorizationServer
Trying to configure method "setAuthorizationServer" which cannot be configured because it does not exist, has not been specified, is final, or is static
coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.2%) to 85.466% when pulling dd78d0097e06b976bde7a3b0fc5a6a4d622556ed on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.2%) to 85.466% when pulling dd78d0097e06b976bde7a3b0fc5a6a4d622556ed on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

prolic commented 8 years ago

see: https://github.com/basz/zfr-oauth2-server/pull/1

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.2%) to 85.466% when pulling 460be53d7c1a5ba885166302c11c31b69b0f80b4 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.2%) to 85.466% when pulling 23982902bcf94d88974d1168c31afdf8be5af590 on basz:minor-things into 1cc24a01262e724da46af0cd909956704d3a9f32 on zf-fr:master.

bakura10 commented 8 years ago

Side question: is there a way to deactivate all those Coveralls notification emails? Being quite spammed by those :(.

basz commented 8 years ago

Should be here, but i don't see what they describe

I don't how to disable emails, but I did change the alert settings thresholds... 

If you would like to change the default notification settings for a repo, first go to the repository's detail view by clicking on the repo name from your repo index. On the detail view, you'll now see a nice, (not)shiny, new button labeled notifications:
basz commented 8 years ago

rebased to avoid merge conflict. i'm done with this, before 'minor thing' become 'not so minor' :-)

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 43ebc1044792826ddf929d60d60dc5777bf95465 on basz:minor-things into \ on zf-fr:master**.

prolic commented 8 years ago

@basz please notify when ready for final review

basz commented 8 years ago

@prolic ready for final review (build was successful, coveralls was not (why?))

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.1%) to 85.961% when pulling 9c337ceae2cd39cd0a9ece685c1dbaf09d9d310f on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.1%) to 85.961% when pulling e5679cf4372388d85ce57718d1b3046933b29604 on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.1%) to 85.961% when pulling 19a81c35cd1c39bc08d0a00ea6084f1870ba0125 on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+9.1%) to 85.961% when pulling fa701797f349f2fbb181392cf48ae87fe99f89be on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+11.7%) to 88.553% when pulling 53e9fb3b131d880a6acba51c34dd3e9d4efa3a9a on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+13.7%) to 90.497% when pulling 711604a6de450ce45c59f766b3f546cba3933c86 on basz:minor-things into ae6042e2e0f0480a8ee656e768cfe2dd44b76a6a on zf-fr:master.

prolic commented 8 years ago

:fireworks: :+1: