search

zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

Q: container names be interface #64

Closed basz closed 7 years ago

basz commented 7 years ago

Should container names reference Interface where ever possible?

ResourceServer vs ResourceServerInterface AuthorizationServer vs AuthorizationServerInterface

example:

https://github.com/zf-fr/zfr-oauth2-server/blob/master/src/Container/ResourceServerMiddlewareFactory.php#L38 https://github.com/zf-fr/zfr-oauth2-server/blob/a4b9715a17f9bd1f0d2f3254881162ff75accf68/src/Container/AuthorizationRequestMiddlewareFactory.php#L38 https://github.com/zf-fr/zfr-oauth2-server/blob/a4b9715a17f9bd1f0d2f3254881162ff75accf68/src/Container/TokenRequestMiddlewareFactory.php#L38

prolic commented 7 years ago

:+1: for referencing interfaces