zf-fr / zfr-oauth2-server

PHP library for creating an OAuth 2 server (currently proof of concept)
BSD 3-Clause "New" or "Revised" License
36 stars 13 forks source link

remove zend-expressive as it is not required #86

Closed basz closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 48625701b4e71bd8f98fa5c3dd78aa56e28df3c3 on basz:relax-dependency into b15354a20d3169b496852faaab0e43f7536dfab7 on zf-fr:master.

prolic commented 7 years ago

Travis failed

basz commented 7 years ago

time thing again, you have an easy suggestion to mock time?

prolic commented 7 years ago

What's the problem exactly?

basz commented 7 years ago

new DateTime != new DateTime 6ms later... Therefore time comparisons fail sometimes.

prolic commented 7 years ago

I used often something like this:

$dateTime = new DateTimeImmutable('now');
$dateTime = $dateTime->modify('-5 secs');

so it's in the past and I can be sure the next timestamp is good for comparison.