search

zf-hipsters / bootstrap-flash-messenger

Simple implementation of ZF2 flash messengers using bootstrap. Contains easy helpers that will save you a LOT of time.
14 stars 1 forks source link

Not working #1

Closed acelaya closed 10 years ago

acelaya commented 10 years ago

The idea of this module looks good, but I am affraid it does not work.

The first I've seen is that the controller plugin has this namespace.

namespace FlashMessenger\View\Helper;

Insetad of

namespace FlashMessenger\Controller\Plugin;

So an error is thrown when you try to use it, because the autoloader is not able to find the class. Also, it is extending Zend\View\Helper\AbstractHelper instead of Zend\Mvc\Controller\Plugin\AbstractPlugin.

But once that is solved the view helper does not print anything, I am not sure why.

However I insist that the idea is very good. I have forked it and I was planning to add support to titles (I have seen they are hardcoded in the views) and icons (both glyphicons and font awesome icons)

aaronweatherall commented 10 years ago

Yes let me fix that and add the requested changes. It'll be pushed in an hour or so. On 10/11/2013 7:52 PM, "Alejandro Celaya" notifications@github.com wrote:

The idea of this module looks good, but I am affraid it does not work.

The first I've seen is that the controller plugin has this namespace.

namespace FlashMessenger\View\Helper;

Insetad of

namespace FlashMessenger\Controller\Plugin;

So an error is thrown when you try to use it, because the autoloader is not able to find the class. Also, it is extending Zend\View\Helper\AbstractHelper instead of Zend\Mvc\Controller\Plugin\AbstractPlugin.

But once that is solved the view helper does not print anything, I am not sure why.

However I insist that the idea is very good. I have forked it and I was planning to add support to titles (I have seen they are hardcoded in the views) and icons (both glyphicons and font awesome icons)

— Reply to this email directly or view it on GitHubhttps://github.com/zf-hipsters/bootstrap-flash-messenger/issues/1 .

acelaya commented 10 years ago

Thanks!

aaronweatherall commented 10 years ago

Okay, my bad I'd overwritten the helper with an older version. All fixed and I've updated the readme regarding how easy it is to modify the default templates! Let me know how it works for you! If you have any other suggestions, please let me know.

acelaya commented 10 years ago

Now it's working. Thank you.

arthasmx commented 10 years ago

working ?

so, why is this issue still open ?

dkcwd commented 10 years ago

Thanks @arthasmx
Closing for now as issue appears to be resolved.