search

zf1s / zf1

Monorepo of a fork of Zend Framework 1, with all components split into individual composer packages. PHP 5.3-8.3 compatible.
BSD 3-Clause "New" or "Revised" License
59 stars 22 forks source link

Add missing @throws annotations #140

Closed glensc closed 1 year ago

glensc commented 1 year ago

Carry only @throws annotations from https://github.com/zf1s/zf1/pull/138

Which itself was to carry https://github.com/Shardj/zf1-future/pull/104:

cc @kstenschke

glensc commented 1 year ago

@falkenhawk such trivial change which you approved in words but still not merged? I had some idea to carry changes from zf1-future, but if the process is blocked such trivial changes, it really demotivates and questions should this fork just be marked abandoned. or increase the developer team size who can actually approve and merge things?

falkenhawk commented 1 year ago

@glensc I appreciate your expression of disappointment, I'd love to be more involved, and also we have few people in the team with access to push/create pull requests/reviews, but it is not trivial to just allocate time to manage it. (or to find enough motivation)

I guess your comment was meant to be a motivational one, but it is difficult not to take it personal. I want to believe that perhaps you are affected by not having a particularly great day today, or maybe it is just me, being a bit vulnerable by not having a good time at this moment either.

Not actioning on the repo for past 4 weeks is far from abandoning it, I would say.

falkenhawk commented 1 year ago

Not actioning on the repo for past 4 weeks is far from abandoning it, I would say.

and it is not only your PR, as you may see also PRs created by me myself are not merged yet. (also small and trivial ones) and a bigger one (i.e. #141 ) still awaits a free time slot in one's free time to take care of.

Anyway, I should not even feel pushed to spend my time on writing such comments. could we try to encourage each other (as I've been always trying to by even commenting with a word of appreciation on every issue and PR created here) and put toxicity aside, please.